This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [v3 PATCH] Add C++11 <cuchar>


On 13/08/15 10:37 -0400, Ed Smith-Rowland wrote:
Greetings,

Now that most systems have uchar.h for conversion between char16_t* and char32_t* to multibyte (analogue of wchar.h and cwchar) i think we should check off this last little crumb of C++11.

Ooh, I forgot about this, thanks!

	Add C++11 header <cuchar>.
	* acinclude.m4: Regenerate.

This file isn't auto-generated, so the changelog is wrong. Maybe
something like:

 acinclude.m4 (GLIBCXX_ENABLE_CUCHAR): Define.


Index: include/Makefile.am
===================================================================
--- include/Makefile.am	(revision 226808)
+++ include/Makefile.am	(working copy)
@@ -709,6 +709,7 @@
	${c_base_srcdir}/cstring \
	${c_base_srcdir}/ctgmath \
	${c_base_srcdir}/ctime \
+	${c_base_srcdir}/cuchar \
	${c_base_srcdir}/cwchar \
	${c_base_srcdir}/cwctype

@@ -751,10 +752,19 @@
	${c_compatibility_srcdir}/string.h \
	${c_compatibility_srcdir}/tgmath.h \
	${c_compatibility_srcdir}/time.h \
+	${c_compatibility_srcdir}/uchar.h \
	${c_compatibility_srcdir}/wchar.h \
	${c_compatibility_srcdir}/wctype.h
endif

+if ENABLE_CUCHAR
+cuchar_headers = \
+	${c_base_srcdir}/cuchar \
+	${c_compatibility_srcdir}/uchar.h
+else
+cuchar_headers =
+endif

This cuchar_headers variable doesn't seem to be used anywhere, am I
missing something?

It looks like the headers are installed unconditionally, and this
ENABLE_CUCHAR block isn't needed (and so the GLIBCXX_CONDITIONAL that
creates it in acinclude.m4 isn't needed either).


+// Copyright (C) 2013 Free Software Foundation, Inc.

A few of the new files have 2013 as the copyright date, not 2015
(I'm always forgetting to update the dates when I return to old
patches that have been uncommitted for a while!)



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]