Re: Fwd: [PATCH]Remve xfail for wrapped target from libstdc++-v3/testsuite/27_io/ios_base/sync_with_stdio/1.cc

[Jonathan Wakely <jwakely at redhat dot com>]

On 05/02/15 11:28 +0000, Renlin Li wrote:
> Hi all,
>
> This patch simply remove the target selector. It should pass for all target which applies.
>
> The comment in the code is not correct. stderr is redirected, not the stdout.
> Therefore, the return status which is streamed into stdout should properly captured even by wrapped target.

The history of this test is curious. Paolo changed the redirect to fix
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=14866 but then a year
later Mark added the support for the "unwrapped" effective target to
XFAIL this test, adding the incorrect comment ... even though
presumably it wasn't actually failing after Paolo's fix! Maybe Mark
was merging something from a CodeSourcery branch where the test still
failed.

The "unwrapped" target is used elsewhere in gcc/testsuite so it's
still useful even if we remove it from this libstdc++ test.

> Okay for trunk?

OK, thanks.


> libstdc++-v3/ChangeLog:
>
> 2015-02-03  Renlin Li<renlin.li@arm.com>
>
> 	* testsuite/27_io/ios_base/sync_with_stdio/1.cc: Remve xfail for wrapped target.

> diff --git a/libstdc++-v3/testsuite/27_io/ios_base/sync_with_stdio/1.cc b/libstdc++-v3/testsuite/27_io/ios_base/sync_with_stdio/1.cc
> index 6edaef3..1c9fa60 100644
> --- a/libstdc++-v3/testsuite/27_io/ios_base/sync_with_stdio/1.cc
> +++ b/libstdc++-v3/testsuite/27_io/ios_base/sync_with_stdio/1.cc
> @@ -23,12 +23,6 @@
> // @require@ %-*.tst
> // @diff@ %-*.tst %-*.txt
>
> -// This test fails on platforms using a wrapper, because this test
> -// redirects stdout to a file and so the exit status printed by the
> -// wrapper is not visibile to DejaGNU.  DejaGNU then assumes that the
> -// test exited with a non-zero exit status.
> -// { dg-do run { xfail { ! unwrapped } } }
> -
> #include <cstdio>
> #include <sstream>
> #include <iostream>