This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Patch, libstdc++/64680] Conform the standard regex interface
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: Tim Shen <timshen at google dot com>
- Cc: Paolo Carlini <paolo dot carlini at oracle dot com>, libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 21 Jan 2015 11:51:31 +0000
- Subject: Re: [Patch, libstdc++/64680] Conform the standard regex interface
- Authentication-results: sourceware.org; auth=none
- References: <CAG4ZjNkJJD1S8Dz4y9_7DCo9qq=5Kg1ZPXUaJCdcJnCK-i5+tg at mail dot gmail dot com> <54BE8A94 dot 8000603 at oracle dot com> <CAG4ZjNnt+pObRS0f7E3vHnLmpPLUrjPEnCb2Av2EKFWaFBe1Fg at mail dot gmail dot com>
On 20/01/15 20:05 -0800, Tim Shen wrote:
On Tue, Jan 20, 2015 at 9:04 AM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
When we end up doing this to save run time, let's at least add in a comment
the PR #, like
// PR libstdc++/64680
before test02().
Certainly.
--
Regards,
Tim Shen
commit a150869847b7b02f57873fc18853b144a61c8880
Author: timshen <timshen@google.com>
Date: Tue Jan 20 00:20:14 2015 -0800
PR libstdc++/64680
* include/bits/regex.h (basic_regex<>::basic_regex,
basic_regex<>::operator=, basic_regex<>::imbue): Conform the
"Conform to ..."
standard interface.
* testsuite/28_regex/basic_regex/assign/char/cstring.cc: New testcase.
As it's a tiny change it's OK for trunk with that tweak to the changelog.
(Any more non-regression regex bugs that get reported might have to
wait for stage 1 and get fixed for the next release)