This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Ping] Port of VTV for Cygwin and MinGW
- From: Caroline Tice <cmtice at google dot com>
- To: Patrick Wollgast <patrick dot wollgast at rub dot de>
- Cc: Kai Tietz <ktietz70 at googlemail dot com>, Benjamin De Kosnik <bkoz at gnu dot org>, "jwakely at redhat dot com >> Jonathan Wakely" <jwakely at redhat dot com>, Ian Lance Taylor <iant at google dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, libstdc++ at gcc dot gnu dot org
- Date: Mon, 12 Jan 2015 10:27:35 -0800
- Subject: Re: [Ping] Port of VTV for Cygwin and MinGW
- Authentication-results: sourceware.org; auth=none
- References: <53FF0C8C dot 8090507 at rub dot de> <5411213F dot 1070104 at rub dot de> <CABtf2+RU7frwOXOX2FF8Tmfc6ssrpfFVj1Vuue4cZt19FpSWtQ at mail dot gmail dot com> <CABtf2+QWxvv1FUW_-kD3d0FBhYQWkZcPWAx8ASies_4j7thmoA at mail dot gmail dot com> <541B5B7E dot 2090300 at rub dot de> <20140923102235 dot GJ2669 at redhat dot com> <542344CB dot 6050600 at rub dot de> <CAEwic4b+KWO3pWQN_sbXqyf2MNWdnN8ZpaUKBVY8ECSqhe0cYg at mail dot gmail dot com> <54369316 dot 7070001 at rub dot de> <CAEwic4bT+OBQcatruiZ5Cnv1d6YMGckuf4Auf9+WzKLchNNZEg at mail dot gmail dot com> <543F9BB8 dot 1040503 at rub dot de> <54524B43 dot 7000105 at rub dot de> <5463893D dot 50807 at rub dot de> <CAEwic4YwnLjJCLii=AdG_-RXEnS3=b1nK90FA5iEsd497aRn8g at mail dot gmail dot com> <54639CC5 dot 4050508 at rub dot de> <CAEwic4YUkQfCo+hZi5BrYyurWzZ7FxLBxaR=HL5TuBdB38ePuA at mail dot gmail dot com> <5476F20C dot 5010801 at rub dot de> <548876B5 dot 70306 at rub dot de> <54A99E34 dot 2010202 at rub dot de> <54AEE9B0 dot 3010407 at rub dot de>
On Thu, Jan 8, 2015 at 12:33 PM, Patrick Wollgast
<patrick.wollgast@rub.de> wrote:
> A short recap again:
>
> Latest patch, changelog and a test program (further information about
> the program in the mail):
> https://gcc.gnu.org/ml/gcc-patches/2014-11/msg03368.html
>
>
> Approved:
> * gcc/config/i386/*
> * libgcc/*
> * libstdc++-v3/*
> * libvtv/* (Some changes made to three of these files.
> Listed in 'Not approved'.)
>
>
> Not approved:
> For the following two files I added checks, if TARGET_PECOFF is defined
> ( https://gcc.gnu.org/ml/gcc-patches/2014-10/msg00815.html )
> * gcc/cp/vtable-class-hierarchy.c
> * gcc/varasm.c
The changes in gcc/cp/vtable-class-hierarchy.c and gcc/varasm.c both
look good to me. However I am not authorized to approve stuff in this
part of GCC, so I need someone with global approval rights to look at
these changes and give the final OK.
>
> Reasons for changes in the following files stated in
> https://gcc.gnu.org/ml/gcc-patches/2014-10/msg00815.html and in the mail
> of the latest patch.
>
> Removed implementation of mprotect.
> * libvtv/vtv_malloc.cc
> Added extern "C" to the prototype of mprotect.
> * libvtv/vtv_malloc.h
> Exchanged call to TerminateProcess with call to abort in __fortify_fail.
> * libvtv/vtv_rts.cc
The changes in libvtv all look good to me (approved).
-- Caroline Tice
cmtice@google.com
>
> Has been removed from the most recent patch. Just listed for completeness.
> * libiberty/obstack.c
>
>
> Regards,
> Patrick