This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: libstdc++ testsuite make targets check-parallel and check-performance don't work anymore
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: Paolo Carlini <paolo dot carlini at oracle dot com>
- Cc: Rainer Emrich <rainer at emrich-ebersheim dot de>, gcc at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Tue, 4 Nov 2014 03:36:54 +0000
- Subject: Re: libstdc++ testsuite make targets check-parallel and check-performance don't work anymore
- Authentication-results: sourceware.org; auth=none
- References: <54579773 dot 60601 at emrich-ebersheim dot de> <5457AAF8 dot 5060403 at oracle dot com>
On 03/11/14 17:19 +0100, Paolo Carlini wrote:
Hi,
On 11/03/2014 03:55 PM, Rainer Emrich wrote:
Since the recent changes to the testsuites the folowing make targets in the
libstdc++ testsuite directory don't work anymore:
check-parallel
check-performance
check-performance-parallel
Any comments?
All I can see so far is a non-conforming use of default arguments (ie,
repeated in the function template definitions) in
include/parallel/algo.h, which the front-end didn't catch until quite
recently (not in 4.9.x). See below what I mean to apply to fix that.
Not sure if you meant something else (too) in your terse message,
tough.
<parallel/numeric> has the same problem, fixed with this patch.
commit 356183f393d2fce9beb5b2d4772b9f8ab83280cd
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Tue Nov 4 03:33:07 2014 +0000
* include/parallel/numeric.h: Do not use default arguments in function
template redeclarations (definitions).
diff --git a/libstdc++-v3/include/parallel/numeric b/libstdc++-v3/include/parallel/numeric
index 8254635..e89f27e 100644
--- a/libstdc++-v3/include/parallel/numeric
+++ b/libstdc++-v3/include/parallel/numeric
@@ -85,8 +85,7 @@ namespace __parallel
__accumulate_switch(__RAIter __begin, __RAIter __end,
_Tp __init, _BinaryOperation __binary_op,
random_access_iterator_tag,
- __gnu_parallel::_Parallelism __parallelism_tag
- = __gnu_parallel::parallel_unbalanced)
+ __gnu_parallel::_Parallelism __parallelism_tag)
{
if (_GLIBCXX_PARALLEL_CONDITION(
static_cast<__gnu_parallel::_SequenceIndex>(__end - __begin)
@@ -193,8 +192,7 @@ namespace __parallel
_BinaryFunction2 __binary_op2,
random_access_iterator_tag,
random_access_iterator_tag,
- __gnu_parallel::_Parallelism __parallelism_tag
- = __gnu_parallel::parallel_unbalanced)
+ __gnu_parallel::_Parallelism __parallelism_tag)
{
if (_GLIBCXX_PARALLEL_CONDITION((__last1 - __first1)
>= __gnu_parallel::_Settings::get().
@@ -419,8 +417,7 @@ namespace __parallel
random_access_iterator_tag,
random_access_iterator_tag,
__gnu_parallel::_Parallelism
- __parallelism_tag
- = __gnu_parallel::parallel_balanced)
+ __parallelism_tag)
{
if (_GLIBCXX_PARALLEL_CONDITION(
static_cast<__gnu_parallel::_SequenceIndex>(__end - __begin)