This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] gcc parallel make check
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Christophe Lyon <christophe dot lyon at linaro dot org>
- Cc: Mike Stump <mikestump at comcast dot net>, VandeVondele Joost <joost dot vandevondele at mat dot ethz dot ch>, David Malcolm <dmalcolm at redhat dot com>, "gcc at gcc dot gnu dot org" <gcc at gcc dot gnu dot org>, "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>
- Date: Fri, 10 Oct 2014 16:54:13 +0200
- Subject: Re: [PATCH] gcc parallel make check
- Authentication-results: sourceware.org; auth=none
- References: <20140911080640 dot GP17454 at tucnak dot redhat dot com> <20140911145300 dot GR17454 at tucnak dot redhat dot com> <908103EDB4893A42920B21D3568BFD93150F876D at MBX23 dot d dot ethz dot ch> <908103EDB4893A42920B21D3568BFD93150FE8D2 at MBX13 dot d dot ethz dot ch> <20140912163241 dot GC17454 at tucnak dot redhat dot com> <305370A6-ACBC-4DD4-AF96-32B3503F3388 at comcast dot net> <20140915160549 dot GM17454 at tucnak dot redhat dot com> <CAKdteOZrsdQ3KCN5XyXOA0H-PnJNJ1ZgMEevNysonrAHDTKHeQ at mail dot gmail dot com> <20141010141956 dot GL10376 at tucnak dot redhat dot com> <CAKdteOYod+3NP-9oYucKPMYG9axS=d9p0GMt1JgyoFp=r8WTcg at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Oct 10, 2014 at 04:50:47PM +0200, Christophe Lyon wrote:
> On 10 October 2014 16:19, Jakub Jelinek <jakub@redhat.com> wrote:
> > On Fri, Oct 10, 2014 at 04:09:39PM +0200, Christophe Lyon wrote:
> >> my.exp contains the following construct which is often used in the testsuite:
> >> ==========
> >> foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.c]] {
> >> # If we're only testing specific files and this isn't one of them,
> >> skip it.
> >> if ![runtest_file_p $runtests $src] then {
> >> continue
> >> }
> >> c-torture-execute $src $additional_flags
> >> gcc-dg-runtest $src "" $additional_flags
> >> }
> >> ==========
> >> Note that gcc-dg-runtest calls runtest_file_p too.
> >
> > Such my.exp is invalid, you need to guarantee gcc_parallel_test_run_p
> > is run the same number of times in all instances unless
> > gcc_parallel_test_enable has been disabled.
>
> Thanks for your prompt answer.
>
> Is this documented somewhere, so that such cases do not happen in the future?
Feel free to submit a documentation patch.
> It's in a patch which has been under review for quite some time
> (started before your change), that's why you missed it.
Ah, ok.
> What about my remark about:
> > # For parallelized check-% targets, this decides whether parallelization
> > # is desirable (if -jN is used and RUNTESTFLAGS doesn't contain anything
> > # but optional --target_board or --extra_opts arguments). If desirable,
> I think it should be removed from gcc/Makefile.in
Only the " and RUNTESTFLAGS ... arguments" part of that. Patch preapproved.
Jakub