This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] Add libstdc++ baseline_symbols for aarch64
- From: Christophe Lyon <christophe dot lyon at linaro dot org>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: Jonathan Wakely <jwakely at redhat dot com>, libstdc++ at gcc dot gnu dot org, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 3 Oct 2014 10:54:05 +0200
- Subject: Re: [PATCH] Add libstdc++ baseline_symbols for aarch64
- Authentication-results: sourceware.org; auth=none
- References: <87mw9mm53a dot fsf at igel dot home> <20140929095630 dot GA13631 at redhat dot com> <CAKdteObcOsejsv4tG-6X_g8ooVrQFpAjtQKuG_smv1AycS=VSg at mail dot gmail dot com> <87oattbn9k dot fsf at igel dot home>
On 3 October 2014 09:55, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Christophe Lyon <christophe.lyon@linaro.org> writes:
>
>> I've looked at debug info from dejagnu, and it really seems that
>> abi_check is called with no argument, hence the error.
>>
>> What am I doing wrong?
>
> That must be something unrelated, hidden since that test was never run
> before. testsuite/libstdc++-abi/abi.exp clearly runs abi_check with the
> right arguments:
>
> set result [${tool}_load "./abi_check" \
> [list "--check-verbose" "current_symbols.txt" \
> "baseline_symbols.txt"]]
Yes, I have seen that, but my dejagnu traces have this:
[...]
call_remote download arm-sim current_symbols.txt current_symbols.txt
[...]
call_remote load arm-sim ./abi_check {--check-verbose
current_symbols.txt baseline_symbols.txt} {}
[...]
call_remote spawn arm-sim ./abi_check
[...]
spawning command /XXX/qemu-wrapper.sh ./abi_check
so at some point the arguments are discarded.
In my site.exp, I have
set target_list { "arm-sim" }
global SIM
set SIM "/XXX/qemu-wrapper.sh"
Not sure why I have this "arm-sim" here.
Maybe that's the reason for the problem I am seeing.
>
> Does it work if you run it manually?
>
Yes, manually I get this:
[list of symbols etc...]
==== libstdc++-v3 check-abi Summary ====
# of added symbols: 136
# of missing symbols: 0
# of undesignated symbols: 2
# of incompatible symbols: 136
using: baseline_symbols.txt
*** EXIT code 1
> Andreas.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
> "And now for something completely different."