This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH libstdc++ v5] - Add xmethods for std::vector and std::unique_ptr
- From: Siva Chandra <sivachandra at google dot com>
- To: Jonathan Wakely <jwakely at redhat dot com>
- Cc: Jonathan Wakely <jwakely dot gcc at gmail dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, "libstdc++" <libstdc++ at gcc dot gnu dot org>, Doug Evans <dje at google dot com>
- Date: Wed, 3 Sep 2014 15:47:07 -0700
- Subject: Re: [PATCH libstdc++ v5] - Add xmethods for std::vector and std::unique_ptr
- Authentication-results: sourceware.org; auth=none
- References: <CAGyQ6gxAYwoi3gLkH-Ut_qRfHpTbV0Dke+bd9BRk_e7cWj4nOA at mail dot gmail dot com> <CAH6eHdQ11T1fvW5hNTL9NMYaKBkCzu2_7=gv1qVvRswwZVh+YQ at mail dot gmail dot com> <CAGyQ6gwFrbVc6w=y6jo9HtRjLw7aV04eLg9Mp7Qp_ps5YqD1VA at mail dot gmail dot com> <CAH6eHdSGpuRtLNphS-sJ-u6m2phMJ5Rh=SCqty1=VCKvnGehDA at mail dot gmail dot com> <CAGyQ6gxB-Xc7t7ZhSh-s9aGQ3P-V+=LZJ+2_pVE4-6i1yRFGKQ at mail dot gmail dot com> <20140903223442 dot GV22778 at redhat dot com>
On Wed, Sep 3, 2014 at 3:35 PM, Jonathan Wakely <jwakely@redhat.com> wrote:
> I was waiting to see which version of the patch actually works, so
> that users can use the xmethods. There's no point committing the patch
> if they aren't installed and can't be used!
Doesn't the latest version of the patch I posted work for you:
https://gcc.gnu.org/ml/gcc-patches/2014-08/msg02516.html
If not, what errors or missing things do you see?
> Also, Tom had objections to the most recent patch, which haven't been
> addressed.
I am a bit confused about his suggestion and hence I asked if it can
be addressed as a follow up. It seems to me like his suggestion is a
code cleanup, but I am not really sure what the aim of the cleanup is.
To avoid mixing up discussing that versus the aim the patch in
question, I am asking if it can addressed as a follow up.
Thanks,
Siva Chandra