This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: testsuite allocators patch

From: Jonathan Wakely <jwakely at redhat dot com>
To: François Dumont <frs dot dumont at gmail dot com>
Cc: Paolo Carlini <paolo dot carlini at oracle dot com>, Jonathan Wakely <jwakely dot gcc at gmail dot com>, "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Tue, 29 Jul 2014 20:27:53 +0100
Subject: Re: testsuite allocators patch
Authentication-results: sourceware.org; auth=none
References: <53A49B7C dot 5080506 at gmail dot com> <53AB276F dot 10806 at gmail dot com> <20140626103353 dot GA1725 at redhat dot com> <53AC8678 dot 5060706 at gmail dot com> <53AC8ED5 dot 3070000 at oracle dot com> <20140626223858 dot GK2711 at redhat dot com> <53AD1CCC dot 2010309 at oracle dot com> <CAH6eHdSBk9t4JR1pRLXve5f8espKBFhF+QcDhXeeCSNFFsTy0Q at mail dot gmail dot com> <53ADCA79 dot 2090007 at oracle dot com> <53D01C0B dot 2030203 at gmail dot com>

On 23/07/14 22:33 +0200, François Dumont wrote:

On 27/06/2014 21:48, Paolo Carlini wrote:
Hi,

On 06/27/2014 07:33 PM, Jonathan Wakely wrote:
I didn't see an obvious fix (I'm not sure if the templated constructor
can deduce its argument since the change) but have been out all day
and not had a chance to look into it.
Ok, thanks. I'm reverting the last two libstdc++-v3 commits.

Paolo.
Hi

   Back from vacation, ready to have this patch committed eventually.

   Here is the new version with the missing default and copy constructor.
I have a small question regarding some code next to the one I ammodifying in this patch. I can see lines like:
     propagating_allocator() noexcept = default;
When using a default implementation shouldn't we let the compilerdecide if it should be noexcept or not depending on the member fieldsor base class default constructors ?
   Tested under Linux x86_64.

   Ok to commit ?


OK, thanks.

References:
- Re: testsuite allocators patch
  - From: FranÃois Dumont

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]