This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [patch 3/N] std::regex refactoring - _Executor DFS / BFS
- From: Tim Shen <timshen91 at gmail dot com>
- To: Jonathan Wakely <jwakely at redhat dot com>
- Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 28 Apr 2014 16:05:29 -0400
- Subject: Re: [patch 3/N] std::regex refactoring - _Executor DFS / BFS
- Authentication-results: sourceware.org; auth=none
- References: <20140428124003 dot GW928 at redhat dot com> <20140428144659 dot GY928 at redhat dot com> <CAPrifD=Bc4D63KJONG5d7YzX1t73HDm276AKPY5mEOZi942_EA at mail dot gmail dot com> <20140428165121 dot GB928 at redhat dot com> <CAPrifDnRhfm2pCDAN5fRs81g8m45u8Kt40n8NHXLmGJrh8aiOA at mail dot gmail dot com> <20140428191027 dot GD928 at redhat dot com> <CAPrifDnTP8CzJtvZ2kYLXt7+=bij9kHj7acArkHGst_MUsw4sw at mail dot gmail dot com> <20140428192950 dot GE928 at redhat dot com>
On Mon, Apr 28, 2014 at 3:29 PM, Jonathan Wakely <jwakely@redhat.com> wrote:
> I'm testing the attached patch now. It compiles slightly faster
> (-ftime-report shows, as expected, that less time is spent in template
> instantiation).
>
> I'd also like to change __match_mode from a bool to an enum like:
>
> enum _Match_mode { _S_exact_match, _S_prefix_match };
>
> Because I find it easier to read something like:
>
> if (__match_mode == _S_exact_match)
> // ...
>
> rather than
>
> if (__match_mode)
> // ...
Oh this is nice, good to know.
Thanks!
--
Regards,
Tim Shen