This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: n3891 s/shared_mutex/shared_timed_mutex/ is now in C++14


On 19 February 2014 18:20, Jonathan Wakely wrote:
> On 19 February 2014 18:03, Ed Smith-Rowland wrote:
>> Apparently, the class shared_mutex is renamed shared_timed_mutex for C++14.
>> This shared_mutex was implemented for 4.9 so it hasn't been released as shared_mutex in the wild.
>> I know it is late for 4.9 but I think we should consider changing this now on trunk so we don't have a released version with something we know is renamed.
>>
>> I think it is a low risk library-only change. (Famous last words, I know).  No files are renamed.  No guts are changed.  It's purely a name change of the shared_mutex class to be more consistent with the rest of the std library.
>>
>> Here is a patch.  I'll check it tonight.
>> I wanted to initiate the discussion now though.
>
> Personally I think it's too late.  We don't export any symbols from
> the library, so changing the name of a feature labelled as
> experimental isn't a big deal.  We could even retain 'shared_mutex' as
> a typedef for 4.9.1 if we feel the need.

OK, Jakub thinks it's better to change this now, not for 4.9.1, so if
the testsuite all passes (which it should do) then please go ahead and
commit this to trunk.

I'd prefer something descriptive for the ChangeLog entry rather than
the sed command, maybe just move your first line to be the comment for
the header change:

    * include/std/shared_mutex: Rename shared_mutex to shared_timed_mutex.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]