This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch] Fix wide char locale support(like CJK charset) in regex

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Tim Shen <timshen91 at gmail dot com>, libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 18 Oct 2013 02:46:31 +0200
Subject: Re: [Patch] Fix wide char locale support(like CJK charset) in regex
Authentication-results: sourceware.org; auth=none
References: <CAPrifD=NaeDaDApG9=CNhFgt6HFwQu0H-kW85CW=Dm65TAZUKw at mail dot gmail dot com>

Hi,

On 10/18/2013 01:17 AM, Tim Shen wrote:

+  setlocale(LC_ALL, "zh_CN.UTF8");
+  const wchar_t * s = L"ä½ å¥½, ä¸–+ç•Œ";
+  wregex re(s);
+  VERIFY(regex_match_debug(L"ä½ å¥½, ä¸–ä¸–ä¸–ç•Œ", re));

These strings make me a lot nervous: I should check the details of thevarious character sets to tell you something technically accurate (andit's late here ;) but really, why don't we use hexadecimal literals,like we often do, eg, in 27_io/basic_filebuf/seekoff, seekpos, orunderflow ?


Thanks,
Paolo.

Follow-Ups:
- Re: [Patch] Fix wide char locale support(like CJK charset) in regex
  - From: Tim Shen

References:
- [Patch] Fix wide char locale support(like CJK charset) in regex
  - From: Tim Shen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]