This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [patch] Make vector::at() assertion message more useful (try #2)
- From: Paul Pluzhnikov <ppluzhnikov at google dot com>
- To: Paolo Carlini <paolo dot carlini at oracle dot com>
- Cc: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: Wed, 4 Sep 2013 16:36:00 -0700
- Subject: Re: [patch] Make vector::at() assertion message more useful (try #2)
- Authentication-results: sourceware.org; auth=none
- References: <ye6qhae0qpf8 dot fsf at elbrus2 dot mtv dot corp dot google dot com> <5227C1AD dot 7090301 at oracle dot com>
On Wed, Sep 4, 2013 at 4:26 PM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> For sure concat_size would not be Ok, isn't uglified.
I didn't uglify it because it's inside __gnu_cxx namespace.
Does it still need uglification?
>> snprintf_lite(__s, sizeof(__s),
>> _N("vector::_M_range_check: __n (which is %zu) >= "
>> "this->size() (which is %zu)"), __n, this->size());
>
> That seems worth exploring, I agree.
Should snprintf_lite be in __gnu_cxx namespace, or be global and be called
__snprintf_lite(), or ...?
Is the location of the out-of-line code in libstdc++-v3/libsupc++/ ok?
(Would probably be called snprintf_lite.cc or some such.)
Is the version I've assigned to the symbol -- GLIBCXX_3.4.20 -- ok?
Thanks,
--
Paul Pluzhnikov