This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Patch] Rewrite regex matchers
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Tim Shen <timshen91 at gmail dot com>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 30 Aug 2013 15:26:59 +0200
- Subject: Re: [Patch] Rewrite regex matchers
- Authentication-results: sourceware.org; auth=none
- References: <CAPrifDmWL=BD0ojZOKG2dOZHNdD4+wNjtB4smyF64eJywHZ0ag at mail dot gmail dot com>
Hi,
On 08/30/2013 02:05 PM, Tim Shen wrote:
+ const _TraitsT& _M_traits;
+ _FlagT _M_flags;
+ bool _M_is_non_matching;
+ std::set<_CharT> _M_char_set;
+ std::set<pair<_StringT, _StringT>> _M_range_set;
+ _CharClassT _M_class_set;
another, very general comment: now that nothing is decided ABI-wise for
these features, let's pay attention to the layouts, let's make sure that
the data members are ordered in the best way to minimize the size. For
example, when I see a bool sandwiched between big objects something
seems at least weird... Let's make measurements and optimize for 64-bit
but let's double check on 32-bit too.
Paolo.