This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Patch 2/2] Localization problem in regex
- From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- To: Tim Shen <timshen91 at gmail dot com>
- Cc: Paolo Carlini <paolo dot carlini at oracle dot com>, "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 23 Aug 2013 15:57:24 +0100
- Subject: Re: [Patch 2/2] Localization problem in regex
- References: <CAPrifDnYX-GGKycPD1Zcmfuah3i7dXsObQMWKuOGq8iszPETLA at mail dot gmail dot com> <5217398F dot 50202 at oracle dot com> <CAPrifDn_gV92-Mw0n7t3U+QH3EEkCFXJd9Ogpk_PShGJXpJqwg at mail dot gmail dot com> <52177128 dot 1040505 at oracle dot com> <CAPrifDmpbH9ZpnK8UUYOzkPqsB7p=gtG_Sa7QT481dfg-DdB3g at mail dot gmail dot com>
On 23 August 2013 15:53, Tim Shen wrote:
> On Fri, Aug 23, 2013 at 10:26 PM, Paolo Carlini
> <paolo.carlini@oracle.com> wrote:
>> Great. But please but the names of the functions you are changing between
>> round brackets. You have tons of examples everywhere.
>
> ...like this?
Yes, that makes it clear what part of the file is affected. That's
important when searching ChangeLogs to find what change last touched
e.g. basic_regex::assign.