This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch 2/2] Localization problem in regex

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Tim Shen <timshen91 at gmail dot com>
Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 23 Aug 2013 12:29:35 +0200
Subject: Re: [Patch 2/2] Localization problem in regex
References: <CAPrifDnYX-GGKycPD1Zcmfuah3i7dXsObQMWKuOGq8iszPETLA at mail dot gmail dot com>

Hi,

On 08/23/2013 11:17 AM, Tim Shen wrote:

     2013-08-23  Tim Shen<timshen91@gmail.com>

* include/bits/regex.h: Fix callers.

     	* include/bits/regex_compiler.h: Store _Traits reference.
     	* include/bits/regex_executor.h: Add _Traits member for _DFSExecutor.
     	* include/bits/regex_executor.tcc: Likewise.
     	* testsuite/28_regex/algorithms/regex_match/extended/wstring_locale.cc:
     	  New.

Thanks a lot indeed. But: "Fix callers" of *what*?!? And from *where*?To be really honest this kind of ChangeLog entry doesn't make muchsense. Please get used to list the specific functions you are changing.It's important.


Thanks,
Paolo.

Follow-Ups:
- Re: [Patch 2/2] Localization problem in regex
  - From: Tim Shen

References:
- [Patch 2/2] Localization problem in regex
  - From: Tim Shen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]