This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Two <regex> testcases failing for check-debug

From: Tim Shen <timshen91 at gmail dot com>
To: Jonathan Wakely <jwakely dot gcc at gmail dot com>, Paolo Carlini <paolo dot carlini at oracle dot com>
Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Fri, 16 Aug 2013 08:40:12 +0800
Subject: Re: Two <regex> testcases failing for check-debug
References: <520C246E dot 1040400 at oracle dot com> <CAPrifDnvfmVxLhueSOv_xCNrTGpAwQ=4O7FQ0SuMFmAwn8=hyg at mail dot gmail dot com> <CAH6eHdS5mtQdW7DEQVEztQDt0eSUSquM1pojxbOHRjXZDZCh2g at mail dot gmail dot com>

On Thu, Aug 15, 2013 at 5:53 PM, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
> Why not use __s.data() in all cases, instead of &*__s.begin()?  That's
> safe even for an empty vector.

Thanks, I didn't notice that vector's data() is mutable(since string's is not).

Bootstrap Passed, and testsuites with -D_GLIBCXX_DEBUG, with or
without -m32 passed.

Could you please commit this patch for me? I lost my SSH private key :(

Thanks!

-- 
Tim Shen

Attachment: a.patch
Description: Binary data

Follow-Ups:
- Re: Two <regex> testcases failing for check-debug
  - From: Paolo Carlini

References:
- Two <regex> testcases failing for check-debug
  - From: Paolo Carlini
- Re: Two <regex> testcases failing for check-debug
  - From: Tim Shen
- Re: Two <regex> testcases failing for check-debug
  - From: Jonathan Wakely

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]