This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Patch] Whole regex refactoring and current status
- From: Tim Shen <timshen91 at gmail dot com>
- To: Paolo Carlini <paolo dot carlini at oracle dot com>
- Cc: David Kastrup <dak at gnu dot org>, "libstdc++" <libstdc++ at gcc dot gnu dot org>
- Date: Tue, 6 Aug 2013 23:45:36 +0800
- Subject: Re: [Patch] Whole regex refactoring and current status
- References: <CAPrifDkAoudaXf=Rwu7jGiBa8nWf9HUx-TQUNGe5a0krJ7pUug at mail dot gmail dot com> <52001184 dot 5020707 at oracle dot com> <CAPrifDm101hQmhY5ADkGPnkuR5arAgbEg+wrScJY07xLFu1T_w at mail dot gmail dot com> <87txj35v5n dot fsf at fencepost dot gnu dot org> <5200C326 dot 8030300 at oracle dot com>
On Tue, Aug 6, 2013 at 5:34 PM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> That does not exactly make clearer what is missing and what already works.
For the function _M_eat_escape(), I can finish it in hours if I've
known what's missing and what already works. It's about reading
standards. I added a TODO just for indicating my future(reading) work.
Instead of documenting, I'll implement sooner.
> Yeah, I agree. To be honest, adding comments isn't the point of the patch,
> and the terse comment was already there. Still, I'm seriously concerned
> about post-GSOC: either Tim will be able to maintain single handedly the
> code (and likely complete it, since we are talking about a big project, eg,
> all the various basic, extended, awk, grep and egrep variants) or we want
> damn serious documentation everywhere... probably we want it in any case.
So turns out it's better to add `damn serious documentation`
everywhere. I think its OK and easy for me to maintain it after GSoC,
but there may be unpredictable accidents.
Should the most important documentation be implementation status? I
think for the core part(regex_automaton and regex_executor), there's
nothing more than classic algorithms(DFS and BFS, SSSP) and data
structures(Graph).
--
Tim Shen