Re: [Patch] Whole regex refactoring and current status

[Paolo Carlini <paolo dot carlini at oracle dot com>]

Hi,

On 08/06/2013 05:56 AM, David Kastrup wrote:
> > > +
> > > +  // TODO implement it.
> > > +  template<typename _BiIter>
> > > +    void
> > > +    _Scanner<_BiIter>::
> > > +    _M_eat_escape()
> > >
> > > The comment is quite mysterious! A lot of code is already there, and first
> > > blush isn't clear at all what is missing and what already works.
> > Um, What I mean is, it does some things but the support to escaping is
> > not complete;
> > I changed the comment to "TODO complete it."
> That does not exactly make clearer what is missing and what already works.
Yeah, I agree. To be honest, adding comments isn't the point of the 
patch, and the terse comment was already there. Still, I'm seriously 
concerned about post-GSOC: either Tim will be able to maintain single 
handedly the code (and likely complete it, since we are talking about a 
big project, eg, all the various basic, extended, awk, grep and egrep 
variants) or we want damn serious documentation everywhere... probably 
we want it in any case.

Paolo.