This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: Re: PR 57779 New debug check
- From: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- To: David Edelsohn <dje dot gcc at gmail dot com>
- Cc: Francois Dumont <frs dot dumont at gmail dot com>, Paolo Carlini <paolo dot carlini at oracle dot com>, Jonathan Wakely <jwakely dot gcc at gmail dot com>, "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 1 Aug 2013 22:02:31 -0500
- Subject: Re: Re: PR 57779 New debug check
- References: <CAGWvnykA_Hn_Oq-NJaZ+AzrUXLd2bG639xkRWnt2DgvqC0KwjA at mail dot gmail dot com>
On Thu, Aug 1, 2013 at 9:42 PM, David Edelsohn <dje.gcc@gmail.com> wrote:
> This patch broke bootstrap on AIX and probably many other targets.
>
> In file included from /tmp/20130801/powerpc-ibm-aix7.1.0.0/libstdc++-v3/include/
> debug/safe_sequence.h:34:0,
> from /nasfarm/edelsohn/src/src/libstdc++-v3/src/c++11/debug.cc:
> 26:
> /tmp/20130801/powerpc-ibm-aix7.1.0.0/libstdc++-v3/include/debug/functions.h: In
> function 'bool __gnu_debug::__foreign_iterator_aux4(const __gnu_debug::_Safe_ite
> rator<_Iterator, _Sequence>&, _InputIterator, _PointerType1, _PointerType2)':
> /tmp/20130801/powerpc-ibm-aix7.1.0.0/libstdc++-v3/include/debug/functions.h:189:
> 6: error: 'addressof' is not a member of 'std'
> __l(std::addressof(*__other),
> ^
This is a libstdc++ bug. The file debug/functions.h is missing the inclusion of
<memory>
By the way, looking at the code, I think the local objects __l and __ge should
be declared constexpr. That is not required, but it is good to annotate places
where the code is conceptually "pure".
-- Gaby