Re: [PATCH, libstdc++] Add proper OpenBSD support

[Mark Kettenis <mark dot kettenis at xs4all dot nl>]

> Date: Sun, 9 Sep 2012 21:07:39 +0100
> From: Jonathan Wakely <jwakely.gcc@gmail.com>
> 
> On 4 September 2012 20:26, Mark Kettenis wrote:
> > Fixes a few testcases.  Mostly based on the existing
> > NetBSD/FreeBSD/Darwin code.
> >
> > 2012-09-04  Mark Kettenis  <kettenis@openbsd.org>
> >
> >         * configure.host (*-*-openbsd*) Set cpu_include_dir.
> >         * config/os/bsd/openbsd/ctype_base.h: New file.
> >         * config/os/bsd/openbsd/ctype_configure_char.cc: New file.
> >         * config/os/bsd/openbsd/ctype_inline.h: New file.
> >         * config/os/bsd/openbsd/os_defines.h: New file.
> 
> This patch is OK, thanks.  Do you want me to commit it for you?

Yes please.

> It shouoldn't stop the patch going in, but I assume that this test
> fails on OpenBSD even with your patch applied?
> 
> #include <locale>
> #include <assert.h>
> 
> class gnu_ctype: public std::ctype<wchar_t> { };
> 
> int main()
> {
>   gnu_ctype gctype;
> 
>   assert(gctype.is(std::ctype_base::xdigit, L'a'));
> }

Interestingly enough, it doesn't fail without my diff.  But it does
fail for OpenBSD's system compiler (GCC 4.2.1 with a lot of local
modifications).  As far as I can determine this is the result of
ctype_base::mask being an 8-bit integer type which doesn't go well
with the generic ctype_members.cc implementation.  Probably need to
have an OpenBSD-specific implementation just like newlib.  Looking
into that now.

Thanks again,

Mark