This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PR 53115

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: François Dumont <frs dot dumont at gmail dot com>
Cc: "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>
Date: Sun, 29 Apr 2012 12:42:47 +0200
Subject: Re: PR 53115
References: <4F9D1625.2050308@gmail.com>

On 04/29/2012 12:21 PM, François Dumont wrote:

Hi

Here is the patch for this PR. We were using buckets before updating them after having inserted equivalents elements one after the another.

2012-04-29 François Dumont <fdumont@gcc.gnu.org>
    PR libstdc++/53115
    * include/bits/hashtable.h
    (_Hashtable<>::_M_rehash_aux(size_type, false_type)): Fix buckets
    after insertion of several equivalent elements.
    * testsuite/23_containers/unordered_multiset/insert/53115.cc: New.
Tested undex linux x86_64 in the 4.7 branch, normal and debug mode.

Ok to commit ?

Ok, but please also add a similar testcase for unordered_multimap. Also - just in case isn't obvious enough - please run such testcases through valgrind.

Thanks!
Paolo.

References:
- PR 53115
  - From: François Dumont

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]