This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Should _GLIBCXX_DEBUG affect tr1/array?


On Wed, Jan 18, 2012 at 11:40 AM, Paolo Carlini <pcarlini@gmail.com> wrote:
> Hi,
>
>> On Wed, 18 Jan 2012, Paolo Carlini wrote:
>>
>>> On 01/18/2012 05:40 PM, Edward Rosten wrote:
>>>> On Fri, Jan 13, 2012 at 6:41 PM, Jonathan Wakely<jwakely.gcc@gmail.com> wrote:
>>>>> I've opened http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51850
>>>>> Patches welcome :)
>>>> I've submitted a patch, and it seems to generate the right aborts in
>>>> the right places.
>>> I had a look, and besides the rather simple formatting, stylistic, etc, things, and of course the Copyright assignment issues, my take on the issue is that we should leave tr1 alone and handle the debug-mode std::array like all the other debug-mode containers, thus separate namespace, etc... At least, I would do that.
>>
>> There is precedent for not separating the debug mode when it doesn't change the types but just the implementation of some functions (valarray and string for instance, but grep finds more), to avoid duplicating too much code.
>
> Well here the code is definitely not much and on the other hand string and valarray are quite special, array is in chap 23, I think we should handle it consistently with the other containers.

I agree with what Paolo said.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]