This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] [4.6] shared_ptr needs explicit copy constructor


On 3 January 2012 21:48, Chase Douglas wrote:
> On 01/03/2012 01:38 PM, Jonathan Wakely wrote:
>> I get testsuite failures with this change applied:
>>
>> FAIL: 20_util/shared_ptr/cons/43820_neg.cc ?(test for errors, line 858)
>> FAIL: 20_util/shared_ptr/cons/43820_neg.cc (test for excess errors)
>> FAIL: 20_util/weak_ptr/comparison/cmp_neg.cc ?(test for warnings, line 354)
>> FAIL: 20_util/weak_ptr/comparison/cmp_neg.cc ?(test for warnings, line 1085)
>> FAIL: 20_util/weak_ptr/comparison/cmp_neg.cc (test for excess errors)
>>
>> Did you not see them when testing?
>
> They didn't affect me when I ran my own library's test suite, and they
> didn't cause the packaged build for Ubuntu to fail. I saw there were
> many test failures in the Ubuntu packaged version, so I didn't really
> pick through them.

We don't care about your library or about the Ubuntu package :)

If you're proposing a change to the FSF sources for GCC then you need
to build and test the change against the FSF sources, and the
libstdc++ testsuite is currently error-free on the 4.6 branch (e.g.
see this report
http://gcc.gnu.org/ml/gcc-testresults/2012-01/msg00208.html on the
gcc-testresults list) so we don't want a change which introduces
failures. Unfortunately those particular files need to be adjusted
whenever any lines are added or removed from shared_ptr.h


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]