This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] [4.6] shared_ptr needs explicit copy constructor


On 3 January 2012 20:45, Chase Douglas wrote:
> On 01/03/2012 12:34 PM, Jonathan Wakely wrote:
>> On 3 January 2012 19:17, Chase Douglas wrote:
>>>
>>> PR c++/50500
>>> * include/bits/shared_ptr.h: Add lazy copy ops even if there's a move
>>
>> That is the ChangeLog for the front-end part of 50500, isn't it?
>> Should be something like "Default copy ctor and assignment."
>
> I just copied the changelog text from commit 180159. That was the
> suggested approach in the style guidelines, though I do agree that
> "Default copy ctor and assignment" makes more sense. What do you suggest
> I do?

Use the text from the libstdc++-v3/ChangeLog for the shared_prt.h change:
http://gcc.gnu.org/viewcvs/trunk/libstdc%2B%2B-v3/ChangeLog?r1=180159&r2=180158&pathrev=180159

You can look in libstdc++-v3/ChangeLog to find that too.

Jason's commit message was the text from gcc/cp/ChangeLog, but he
touched several parts (the C++ front-end, the C++ library and the
testsuite) which all have their own ChangeLog files.


>> Otherwise this is OK to check in, thanks.
>>
>> (Do you need me to do the actual check in or can Matthias do it?)
>
> I don't know if Matthias can do it. I copied him to keep him in the loop
> since he is the toolchain maintainer for Ubuntu and I would like to get
> this into the next release. If you have access, I would suggest you do
> it since Matthias hasn't been involved in the generation or review of
> this patch.

OK, I'll do it.

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]