This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] [4.6] shared_ptr needs explicit copy constructor
On 3 January 2012 17:13, Stephen M. Webb wrote:
> On 01/03/2012 12:01 PM, Jonathan Wakely wrote:
>> On 3 January 2012 16:59, Jonathan Wakely wrote:
>>> On 3 January 2012 16:23, Chase Douglas wrote:
>>>> When compiling with a compiler that is conformant to the c++11
>>>> spec for PR c++/50500, std::shared_ptr must have an explicitly
>>>> defined copy constructor.
>>>
>>> This has already been fixed in GCC 4.7, see PR 50500
>>
>> Doh, sorry - I should have actually read your message!
>>
>> As I said in 51699, I agree with backporting relevant library
>> fixes, so I'm ok with this change. ?Has it also been testing using
>> G++ 4.6 as the compiler? :)
>
> Maybe if there was a test case to go with the patch....
We can't add a testcase that checks that non-G++ compilers compile our
shared_ptr, which is what this patch is allowing. If it passes the
existing tests in the 4.6 branch then the change is safe for GCC 4.6,
and Chase already stated that it works for Clang++ 3.0