This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [v3] define string::pop_back()

From: Eric Botcazou <ebotcazou at adacore dot com>
To: Jonathan Wakely <jwakely dot gcc at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org, "libstdc++" <libstdc++ at gcc dot gnu dot org>
Date: Mon, 7 Nov 2011 11:57:40 +0100
Subject: Re: [v3] define string::pop_back()
References: <CAH6eHdS5iBXR-KZJRC1wx_TCTN2d2G721dCCu_JtXYG1RgjQZw@mail.gmail.com> <201111071040.23569.ebotcazou@adacore.com> <CAH6eHdRrtm=rpOvNneTpnOaD4VUzQn9OTZxvvhz7bZXw6FhrOg@mail.gmail.com>

> Won't that fail to match string::max_size?

No, if it doesn't appear in the list, then it isn't matched by the regexp.

> For GNU I added a regex for that explicitly:
>
> +    _ZNKSs8max_size*;
> +    _ZNKSbIwSt11char_traitsIwESaIwEE8max_size*;

What is GNU here?  The Solaris version file is a massaged version of gnu.ver.
You patched gnu.ver incorrectly so symbols are now matched twice; you need to 
fix that by avoiding the double matching.

-- 
Eric Botcazou

Follow-Ups:
- Re: [v3] define string::pop_back()
  - From: Jonathan Wakely

References:
- Re: [v3] define string::pop_back()
  - From: Eric Botcazou
- Re: [v3] define string::pop_back()
  - From: Jonathan Wakely

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]