This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: debug unordered_multi erase patch
- From: Paolo Carlini <pcarlini at gmail dot com>
- To: François Dumont <francois dot cppdevs at free dot fr>
- Cc: libstdc++ at gcc dot gnu dot org
- Date: Fri, 26 Nov 2010 23:47:03 +0100
- Subject: Re: debug unordered_multi erase patch
- References: <4CF01CED.4080307@free.fr>
Il 26/11/10 21.47, François Dumont ha scritto:
Hi
debug unordered_multimap and unordered_multiset erase from key are
not correctly implemented and no test was showing this problem.
Ok. A minor nit would be that normally - outside a special case in
std::list if I remember correctly - in the library we *never*
postincrement iterators for performance reasons: agreed, given today's
optimizers, in particular for the pretty simple iterator types of the
std containers, probably this traditional general rule of thumb isn't so
important anymore, but let's stick to it for now (actually, as matter of
style, we don't postincrement *anything*, just in case you didn't notice
already, not even integers)
Please post what you actually will end up committing (and its ChangeLog
entry)
Thanks
Paolo.