This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 21 November 2010 20:55, Paolo Carlini<paolo.carlini@oracle.com> wrote:Nothing wrong of course, you simply advise to use unique_lock in a message following, I though it was making previous advise obsolete.
I still don't see what's wrong with moving the body of swap into a.. first blush looks pretty good to me. But I see now an unconditional use of<mutex>, which isn't always available, see:
...
#if defined(_GLIBCXX_HAS_GTHREADS)&& defined(_GLIBCXX_USE_C99_STDINT_TR1)
...
Thus if we commit this kind of change to debug.cc the bootstrap breaks
for some targets. Please figure out a solution not relying
unconditionally on<mutex>.
separate function, as suggested in
http://gcc.gnu.org/ml/libstdc++/2010-11/msg00063.html
FAIL: 22_locale/messages/members/char/1.cc execution test FAIL: 22_locale/messages/members/char/2.cc execution test FAIL: 22_locale/messages/members/char/wrapped_env.cc execution test FAIL: 22_locale/messages/members/char/wrapped_locale.cc execution test FAIL: 22_locale/messages_byname/named_equivalence.cc execution test FAIL: 22_locale/money_put/put/char/9780-3.cc execution test FAIL: 27_io/basic_istream/seekg/char/26211.cc execution test FAIL: 27_io/basic_istream/seekg/wchar_t/26211.cc execution test FAIL: 27_io/basic_istream/tellg/char/26211.cc execution test FAIL: 27_io/basic_istream/tellg/wchar_t/26211.cc execution test
FAIL: ext/pb_ds/example/hash_illegal_resize.cc execution test FAIL: ext/pb_ds/example/hash_mod.cc execution test FAIL: ext/pb_ds/example/hash_shift_mask.cc execution test FAIL: ext/pb_ds/example/ranged_hash.cc execution test FAIL: ext/pb_ds/regression/hash_data_map_rand.cc execution test FAIL: ext/pb_ds/regression/hash_no_data_map_rand.cc execution test FAIL: ext/pb_ds/regression/list_update_data_map_rand.cc execution test FAIL: ext/pb_ds/regression/tree_data_map_rand.cc execution test FAIL: ext/pb_ds/regression/tree_no_data_map_rand.cc execution test FAIL: ext/pb_ds/regression/trie_data_map_rand.cc execution test FAIL: ext/pb_ds/regression/trie_no_data_map_rand.cc execution test
FAIL: ext/profile/all.cc (test for excess errors) FAIL: ext/profile/mh.cc (test for excess errors) FAIL: ext/profile/profiler_algos.cc (test for excess errors)
Attachment:
ChangeLog.entry
Description: Text document
Attachment:
performance.patch
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |