This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: small profile unordered_map patch
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: François Dumont <francois dot cppdevs at free dot fr>
- Cc: libstdc++ at gcc dot gnu dot org
- Date: Tue, 09 Nov 2010 23:11:06 +0100
- Subject: Re: small profile unordered_map patch
- References: <4CD9BB98.3000306@free.fr>
Hi,
>
> I notice some useless code when I saw the latest
> profile/unordere_map patch. Here is the cleanup tested on x86_64/linux
> using only unordered_map tests and check-profile mode.
The patch is Ok, but please adjust the ChangeLog to something like:
* include/profile/unordered_map (unordered_map<>::_M_profile_resize):
Simplify, don't take a __new_size argument; adjust all callers.
Before committing the patch, remember to add yourself to MAINTAINERS, in
the "Write After Approval" section (please maintain the alphabetical
order), useful also to test that everything is fine in your SVN write
setup...
Thanks!
Paolo.