This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] Robust basic_filebuf::imbue
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: David Krauss <potswa at mac dot com>
- Cc: libstdc++ at gcc dot gnu dot org
- Date: Tue, 12 Oct 2010 13:07:57 +0200
- Subject: Re: [PATCH] Robust basic_filebuf::imbue
- References: <15F914AD-EE57-4F52-9F66-50EB5A329874@mac.com> <4C968FFB.4040306@oracle.com> <6600C4C1-DEC7-4226-B81F-139095BECEAF@mac.com> <4C9950E5.1000101@oracle.com> <4C9A5C84.7060807@oracle.com> <EFADAB42-8073-492B-9BE5-5ABDBD78BFDD@mac.com> <4C9A7913.1070506@oracle.com> <8A1F72C6-534B-476A-93C7-6B7C9466F4FB@mac.com> <695F56CD-0820-459F-97B2-00EA0FED8649@oracle.com> <EF032D5D-DF9E-4B24-A077-50266FD05649@mac.com> <554E2CD9-E307-4B68-8463-46248F900768@gmail.com> <1528DDE3-CCD7-4479-A78E-3F089B2573B3@mac.com> <050C148B-E726-4485-9742-F3102ED6501A@gmail.com> <2FA8D667-3C27-40B8-A520-8ED7E2BCD3CE@mac.com> <D45485D3-3FDC-4335-9D6B-C62149C56C74@mac.com> <4C9BDCD1.6090609@oracle.com> <77FCCA8C-35C8-415F-AFB1-1C774567CC7B@mac.com> <A78CDC60-8B8D-4CAB-A798-5BE72AA7F721@mac.com>
On 10/12/2010 12:21 PM, David Krauss wrote:
> Yikes, there was some very unfortunate commenting in those testcases!
>
> Furthermore, when I uncommented that, one of them failed! But I don't think the bug is in the current code, it's preexisting in basic_filebuf::seekoff, and looks related to something I was already aware of and wanting to fix. It is not returning the correct state with the position in unbuffered mode. So, for now I'm "adding a regression." Will add a fix in a separate patchfile after sleep.
If this is a smaller issue, self-contained in seekoff, can we fix it first?
Paolo.