This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] basic_filebuf: 45628 + non-modal I/O
On 09/24/2010 12:33 AM, David Krauss wrote:
> Turned out I was using _M_codecvt on a closed file. I had to indent
> all of seekoff to fix the bug,
> but otherwise no big deal. Test coverage of that case is pretty good!
>
Great. Now that I can actually see the draft patch, I would suggest the
following candidates for separate patches, to be submitted first.
1- Imbue clean up.
2- General audit for __check_facet, we have very few uses. Is it really
needed? Should be removed altogether? Is the basic_filebuf case really
different?
3- Possibly, protected -> private changes, as already discussed.
There are quite a few issues in the rest of the work, to be dealt with
later.
Paolo.