This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, v3] Do not shift by larger than size in hash_bytes.cc

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>, gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org, Matt Austern <austern at google dot com>
Date: Sun, 19 Sep 2010 10:51:05 +0200
Subject: Re: [PATCH, v3] Do not shift by larger than size in hash_bytes.cc
References: <20100919081607.GD5435@gmx.de>

HI Ralf,

and thanks for noticing the warning,
> Regtested, no regressions.  It seems to me however that the warning
> hints that the code needs more adjustments for 32 bit size_t, or that
> load_bytes and shift_mix can be enclosed in '#if __SIZEOF_SIZE_T__ == 8'
> because they seem unused in the 32 bit case.
yes, I'm going to simply commit the below.

Thanks again,
Paolo.

////////////////

Attachment: CL
Description: Text document

Attachment: p
Description: Text document

References:
- [PATCH, v3] Do not shift by larger than size in hash_bytes.cc
  - From: Ralf Wildenhues

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]