This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [patch] debug mode
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: François Dumont <francois dot cppdevs at free dot fr>
- Cc: libstdc++ at gcc dot gnu dot org
- Date: Wed, 18 Aug 2010 23:17:36 +0200
- Subject: Re: [patch] debug mode
- References: <4C4F3C54.8020106@free.fr> <4C50900B.6030705@oracle.com> <4C53E2FD.5070206@free.fr> <4C545CB5.4090902@oracle.com> <4C545E6D.5050409@oracle.com> <4C6BD03E.1050706@free.fr> <4C6BDBFB.6000307@oracle.com> <4C6C358E.20901@free.fr>
Hi,
> No, there were AFAIR 22 failures, the same one with or without the
> tests. Do you mean that I should undef _GLIBCXX_DEBUG when the test
> don't work with it ? If so I could perhaps do so in an other patch
> dedicated to fixing the debug-check target.
Ok, if you see only the synopsis.cc, the pb_ds (there are some latent
problems there), and the ext/profile failures, that's fine in
debug-mode. Actually, I should clean the ext/profile fails, in
particular profiler_algos.cc, which is new, nothing to do with your
work, anyway.
>
>>> - 80 columns
>>>
>>> Sorry about that I looked for the number of chars and not the
>>> number of columns, because of tabulations it is not equal. By the way,
>>> are tabulations ok ? Most of projects I work on was forbidding tabs,
>>> should I consider that tabs are 8 spaces long ? To fix this problem I
>>> replace many __first, __last by respectively __f, __l, I hope it is
>>> fine.
>>>
>> Certainly tabs are not forbidden, but the indentations must be right, 2
>> chars wide each, essentially.
> Really, with such a width indentation is not right in files I work on,
> with width 8 it looks better.
Well, don't ask my opinion here: I'm so used to the GNU, and libstdc++
in particular, conventions, that *anything* else looks ugly to me ;)
Paolo