This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: libstdc++ and race detectors

From: Paolo Carlini <paolo dot carlini at oracle dot com>
To: Kostya Serebryany <kcc at google dot com>
Cc: Jonathan Wakely <jwakely dot gcc at gmail dot com>, libstdc++ at gcc dot gnu dot org, Julian Seward <jseward at acm dot org>, Bart Van Assche <bvanassche at acm dot org>, "Frank, Matthew I" <matthew dot i dot frank at intel dot com>
Date: Mon, 16 Aug 2010 17:00:22 +0200
Subject: Re: libstdc++ and race detectors
References: <AANLkTim68MweWz6dJkpl4t2Ub6EIlhpgPYas_Gc1WurR@mail.gmail.com> <AANLkTikO34M61MUuOziCfuzAGUYvEwNeybq9ulCvNOxB@mail.gmail.com> <4C3D8A35.60302@oracle.com> <AANLkTilTEp-YkjwTsuvj9UXY9cx168_OJAHQBe0i7n49@mail.gmail.com> <4C3D9A7B.2010107@oracle.com> <AANLkTimyphRPCwv1UPngm1JcAH7CKlXoi7N5Wpix6zVF@mail.gmail.com> <AANLkTimaZI6NhN2ymB3fdkZI8YLDsJ8BUWD8k-RFjQLk@mail.gmail.com> <AANLkTil1nRjJzryXCRhyJfX8jTEHH948app2csV5wqLd@mail.gmail.com> <AANLkTikJ_V3ggetht4TrdP46BW402i3pL6PW98kXuRKH@mail.gmail.com> <AANLkTikTd0BER3rqaYPoJ6pz47GE5rSDrH7s9Bw=jvmT@mail.gmail.com> <4C627D32.9020503@oracle.com> <AANLkTi=oAHjYj4v6XDSb=RnMb0jeJiXCa-WtZMaLp7Bt@mail.gmail.com> <4C63E20C.9070706@oracle.com> <4C647CB7.2070403@oracle.com> <AANLkTimB7uVZBqKnKWk+fQrrAq+echQcynmcxQ28TXF0@mail.gmail.com> <4C654516.5050901@oracle.com> <AANLkTik7cW48P94j5C51ECd3Q0rukQfpCY9_Ny7GHbyj@mail.gmail.com> <AANLkTinbWmVxAOceeQjZaw4M7u6oyET4q=5jkcSoU1HW@mail.gmail.com>

Hi,
> Here is my first draft. Please comment.
> http://codereview.appspot.com/download/issue1974042_1_2.diff
> I validated and built the docs on Ubuntu Lucid using these commands:
>   make doc-xml-validate-docbook
> XSL_STYLE_DIR=/usr/share/xml/docbook/stylesheet/docbook-xsl-ns
> SCHEMA_FLAGS="--dtdvalid
> /usr/share/xml/docbook/schema/dtd/5.0/docbook.dtd"
>   make doc-html-docbook
> XSL_STYLE_DIR=/usr/share/xml/docbook/stylesheet/docbook-xsl-ns
>   
Thanks. The substance of the patch looks ok to me, but honestly I think
the form could be improved - for example I see repetitions (race
detectors - race detectors, these macros - these macros - these macros,
etc).

Jon, can I count on you to improve a bit the English?

Thanks again,
Paolo.

References:
- Re: libstdc++ and race detectors
  - From: Kostya Serebryany
- Re: libstdc++ and race detectors
  - From: Kostya Serebryany
- Re: libstdc++ and race detectors
  - From: Paolo Carlini
- Re: libstdc++ and race detectors
  - From: Kostya Serebryany
- Re: libstdc++ and race detectors
  - From: Paolo Carlini
- Re: libstdc++ and race detectors
  - From: Paolo Carlini
- Re: libstdc++ and race detectors
  - From: Kostya Serebryany
- Re: libstdc++ and race detectors
  - From: Paolo Carlini
- Re: libstdc++ and race detectors
  - From: Kostya Serebryany
- Re: libstdc++ and race detectors
  - From: Kostya Serebryany

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]