This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [v3] PR43820 require complete type in shared_ptr
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 28 May 2010 10:53:54 +0200
- Subject: Re: [v3] PR43820 require complete type in shared_ptr
- References: <AANLkTinaeQObA9pdMJLZXsRNdZnuPeWwjSCAKD-xRZkb@mail.gmail.com>
On 05/27/2010 02:45 PM, Jonathan Wakely wrote:
> PR libstdc++/43820
> * include/bits/shared_ptr_base.h: Require complete type.
> * include/tr1/shared_ptr.h: Likewise.
> * testsuite/20_util/shared_ptr/cons/43820.cc: New.
> * testsuite/tr1/2_general_utilities/shared_ptr/cons/43820.cc: New.
>
> This addresses the shared_ptr part of PR43820.
> Tested x86_64/Linux. I'm away for a few days, will commit to trunk
> when I get back. Although it's a regression this change makes invalid
> uses into a hard error where we only warned in old releases, so I'm
> not sure about applying it to 4.4 and 4.5
>
Hi agree, let's apply this to mainline only. And I think the issue can
be safely closed, let's not fiddle with auto_ptr, really.
Thanks,
Paolo.