This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH][libstdc++-v3 parallel mode] PR 42712 search_n serial fallbacks
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Johannes Singler <singler at kit dot edu>
- Cc: libstdc++ at gcc dot gnu dot org, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 18 Jan 2010 15:21:25 +0100
- Subject: Re: [PATCH][libstdc++-v3 parallel mode] PR 42712 search_n serial fallbacks
- References: <4B54663C.20807@kit.edu> <4B546BF7.6080301@oracle.com>
On 01/18/2010 03:11 PM, Paolo Carlini wrote:
> If I understand correctly what you are doing here, adding the new data
> member at the *end* of the existing ones should minimize the possible
> problems: I think the only existing applications that could break are
> those using sizeof(_Settings), which seems really unlikely to me. Then I
> would consider the trade-off vs parallel-mode stability certainly
> acceptable. What do you think?
>
Well, of course I would suggest you conducting a few little experiments:
preparing a snippet of code running search_n and a couple other
algorithms (among those reading the _Settings data members close to the
one you are adding), compile it pre-patch and keep the binary around.
Then installing the patch, installing the new library, linking the old
binary vs the new library and running it. My hope is that with the new
member at the end, everything should be still fine...
Paolo.