This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH][libstdc++-v3 parallel mode] Patch for PR 39546
- From: Paolo Carlini <paolo dot carlini at oracle dot com>
- To: Johannes Singler <singler at ira dot uka dot de>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>, gcc-patches at gcc dot gnu dot org
- Date: Mon, 04 May 2009 23:17:15 +0200
- Subject: Re: [PATCH][libstdc++-v3 parallel mode] Patch for PR 39546
- References: <49F9B887.8060605@ira.uka.de> <49F9BE91.5080007@oracle.com> <49FF1E98.8010204@ira.uka.de>
Johannes Singler wrote:
> Sorry, got you wrong, test case now included. Have rerun regression tests.
>
> 2009-05-04 Johannes Singler <singler@ira.uka.de>
>
> PR libstdc++/39546
> * include/parallel/algo.h (find_switch):
> Parametrize binder2nd with const T& instead of T.
> * testsuite/25_algorithms/find/39546.cc: new test case
>
Generally ok, but please follow our practice for the testcase: thus have
a separate test01 function, use in it VERIFY (test variable, include
<testsuite_hooks.h>), always indent only 2 spaces at a time, copyright
year only 2009, of course, etc.
Paolo.