This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
ABI check is (potentially) missing some symbol size changes.
- From: Stephen Webb <stephenw at xandros dot com>
- To: libstdc++ at gcc dot gnu dot org
- Date: Wed, 25 Jul 2007 15:01:34 -0400
- Subject: ABI check is (potentially) missing some symbol size changes.
- Reply-to: Stephen Webb <stephenw at xandros dot com>
We noticed that a small coding error in the ABI check utility is causing some
symbol size changes to go undetected. Although nothing is currently being
missed in the mainline codebase, it's possible that something might slip by
in the future.
OK to commit to trunk?
2007-07-25 Stephen M. Webb <stephenw@xandros.com>
Fixed abi_check for missing symbol size changes.
* testsuite/util/testsuite_abi.cc: changed local variable name to
prevent member variable hiding.
Index: testsuite/util/testsuite_abi.cc
===================================================================
--- testsuite/util/testsuite_abi.cc (revision 126913)
+++ testsuite/util/testsuite_abi.cc (working copy)
@@ -61,8 +61,8 @@ symbol::init(string& data)
n = data.find_first_of(delim);
if (n != npos)
{
- string size(data.begin(), data.begin() + n);
- istringstream iss(size);
+ string objectsize(data.begin(), data.begin() + n);
+ istringstream iss(objectsize);
int x;
iss >> x;
if (!iss.fail())
--smw