Re: Search algorithms in __gnu_cxx::

["Dhruv Matani" <dhruvbird at gmail dot com>]

Attached is the patch. All tests passed except one.
Tested x86_64 Suse Linux-10.0

birdman:/mnt/data1/build_gcc/x86_64-suse-linux/libstdc++-v3 # XPASS:
26_numerics/cmath/c99_classification_macros_c.cc (test for excess
errors)
XPASS: 27_io/fpos/14320-1.cc execution test

               === libstdc++ Summary ===

# of expected passes            4453
# of unexpected successes       2
# of expected failures          14
make[2]: *** [check-DEJAGNU] Error 1
make[2]: Leaving directory
`/mnt/data1/build_gcc/x86_64-suse-linux/libstdc++-v3/testsuite'
make[1]: *** [check-am] Error 2
make[1]: Leaving directory
`/mnt/data1/build_gcc/x86_64-suse-linux/libstdc++-v3/testsuite'
make: *** [check-recursive] Error 1


Regards,
-Dhruv.




On 11/14/06, Paolo Carlini <pcarlini@suse.de> wrote:
> Dhruv Matani wrote:
>
> > I've patched on gcc-4.2[gcc version 4.2.0 20061107 (prerelease)]
>
> ... no way to convince you that we always patch *mainline* first...
>
> > Please let me know if you have any other specific requirements in mind.
>
> ... also no way to convince you that we are in a 64-bits era: I can tell
> you immediately that many of your types are wrong, today ints are often
> 32-bits, you can't assign the difference of two iterators to an int, you
> need a difference_type; similarly you cannot assign a size_t to an int,
> because a size_t today is often 64-bits...
>
> While you are at it, please consistently uglify *everything*; don't use
> curly braces for single statement blocks; follow the conventions about
> names of iterator types (from the name must be *obvious* the iterator
> category); index excess *128* because the smallest signed (8-bit) char
> value is -128. There are many additional minor things, but we have time,
> I'd like to see first performance numbers vs current string::find...
>
> Paolo.


--
  -Dhruv Matani.
http://www.geocities.com/dhruvbird/

"Be sure brain is in gear before engaging mouth"
     -- Anonymous

Attachment: boyer_moore.patch.dhruv
Description: Binary data