This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: PATCH: other/17789: Cannot 'make check' inside libstdc++-v3
- From: Phil Edwards <phil at codesourcery dot com>
- To: "H. J. Lu" <hjl at lucon dot org>
- Cc: Paolo Carlini <pcarlini at suse dot de>, gcc-patches at gcc dot gnu dot org, Andreas Schwab <schwab at suse dot de>, libstdc++ at gcc dot gnu dot org
- Date: Sat, 2 Oct 2004 19:40:42 -0400
- Subject: Re: PATCH: other/17789: Cannot 'make check' inside libstdc++-v3
- References: <415D2653.6030505@suse.de> <20041001155756.GB1094@lucon.org> <415D80E4.1050005@suse.de> <20041001214603.GA7148@lucon.org> <415DD2FD.8040809@suse.de> <20041001222528.GA7863@lucon.org> <415DDAF4.7070006@suse.de> <20041001232117.GC8657@lucon.org> <415DF2CB.7010601@suse.de> <20041002232856.GA30503@lucon.org>
- Reply-to: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
Again, for the Nth time, H.J., you need to cc libstdc++@ on patches which
affect it.
On Sat, Oct 02, 2004 at 04:28:56PM -0700, H. J. Lu wrote:
> include $(top_srcdir)/fragment.am
>
> +# Set up library path if needed.
> +@set_gcc_lib_path@
> +
> if GLIBCXX_HOSTED
> hosted_source = libmath src po testsuite
> endif
[...]
>
> include $(top_srcdir)/fragment.am
>
> +# Set up library path if needed.
> +@set_gcc_lib_path@
> +
These need some comments. Pointing to the TC_AM_blahblahblah macro is
probably good enough. Something, at the very least, indicating what's
responsible for setting the value.
Has this been regtested on platforms other than ia64?
--
I would therefore like to posit that computing's central challenge, viz. "How
not to make a mess of it," has /not/ been met.
- Edsger Dijkstra, 1930-2002