This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Patch] Reimplement (and split) istream::ignore
- From: Benjamin Kosnik <bkoz at redhat dot com>
- To: Paolo Carlini <pcarlini at suse dot de>
- Cc: libstdc++ at gcc dot gnu dot org
- Date: Mon, 21 Jun 2004 21:14:51 -0500
- Subject: Re: [Patch] Reimplement (and split) istream::ignore
- Organization: Red Hat / Chicago
- References: <40D5AB9A.5090203@suse.de>
This looks fine Paolo with this one bit:
>+ * NB: Conformingly, we provide three overloads, instead of the single
>+ * function (with defaults) mandated by the Standard: this leads to a
>+ * better performing implementation.
Should be:
>+ * NB: Provide three overloads, instead of the single
>+ * function (with defaults) mandated by the Standard: this leads to a
>+ * better performing implementation, while still conforming to the standard.
You might also want to detail, in an abbreviated summary, why it's a
"better performing implementation."
best,
benjamin