This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] RE: Testsuite problem
- From: Zack Weinberg <zack at codesourcery dot com>
- To: Pétur Runólfsson <peturr02 at ru dot is>
- Cc: "Benjamin Kosnik" <bkoz at redhat dot com>, <libstdc++ at gcc dot gnu dot org>, <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 22 Apr 2004 09:24:42 -0700
- Subject: Re: [PATCH] RE: Testsuite problem
- References: <07D05A69A3D0C14FAEA60C3ACE8E5564028D0EB0@mail.ru.is>
Pétur Runólfsson <peturr02@ru.is> writes:
> Benjamin Kosnik wrote:
>> >The solution is probably to just use ios_base::out, and XFAIL on those
>> >targets where that doesn't work.
>>
>> Yep. If you prepare a patch, and post it, it'll be easier to track this
>> issue. We can sort this out after the release.
>
> OK, this might work. This uses alarm to kill the child process if the
> parent fails to do it's thing. I have verified (by commenting out the
> call to open in the parent) that this works. I'm not sure if the XFAIL
> line is correct, or if XFAIL is needed for more platforms.
I clearly wasn't paying enough attention here. Can you please clarify
why the original patch is incorrect? I do not see why the change made
should have caused the write() operation not to fail.
zw