This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch for the allocator.


On Fri, 2004-03-26 at 18:18, Paolo Carlini wrote:
> Dhruv Matani wrote:
> 
> >>      class _Ffit_finder 
> >>	: public std::unary_function<typename std::pair<_Tp, _Tp>, bool> {
> >>    
> >>
> ':' must be aligned with 'c' (many instances). Watch the open brace

Ok. Onlt for classes or even for initializer lists?

> >>      template <typename _Tp>
> >>      bool
> >>      operator()(_Tp* __pt, _Tp const& __crt) const throw()
> >>    
> >>
> Always indent after 'template'.

Ok.

> >>      	unsigned int *__puse_count = reinterpret_cast<unsigned int*>
> >>	  (_S_mem_blocks[_S_last_request._M_where()].first) -
> >>
> Always split before the operator (a few instances).

Meaning?



Thanks for you scrutiny ;-)




-- 
	-Dhruv Matani.
http://www.geocities.com/dhruvbird/

Proud to be a Vegetarian.
http://www.vegetarianstarterkit.com/
http://www.vegkids.com/vegkids/index.html



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]