This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [Patch] String: move and centralize exp growth
- From: Dhruv Matani <dhruvbird at gmx dot net>
- To: Paolo Carlini <pcarlini at suse dot de>
- Cc: libstdc++ <libstdc++ at gcc dot gnu dot org>
- Date: 28 Jan 2004 09:30:42 +0530
- Subject: Re: [Patch] String: move and centralize exp growth
- Organization:
- References: <4016E332.5010603@suse.de>
On Wed, 2004-01-28 at 03:46, Paolo Carlini wrote:
> Hi,
>
> this is the idea implemented! Honestly, I'm very happy with it: now all
> the "magic numbers" are only in one place (instead of three!), and the
> encapsulation is much better.
>
> I have tested the patch on x86-linux, I would like to do some additional
> tests and, if everything goes well, commit to mainline (only, of course!)
> very soon.
I noticed this in the patch:
*************** namespace std
*** 157,165 ****
const size_type __dnew =
static_cast<size_type>(std::distance(__beg, __end));
Is it really intended, or would you rather use difference_type on the
lhs of the assignment?
--
-Dhruv Matani.
http://www.geocities.com/dhruvbird/