This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: [PATCH] Fix PR libstdc++/13462 std::set's pointer is not right
- From: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- To: Andrew Pinski <pinskia at physics dot uc dot edu>
- Cc: libstdc++ at gcc dot gnu dot org, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: 22 Dec 2003 17:37:44 +0100
- Subject: Re: [PATCH] Fix PR libstdc++/13462 std::set's pointer is not right
- Organization: Integrable Solutions
- References: <90AC01C3-349A-11D8-BB55-000393A6D2F2@physics.uc.edu>
Andrew Pinski <pinskia@physics.uc.edu> writes:
| The problem is that std::set's pointer is defined based on
| _Rep_type::const_pointer and not _Rep_type::pointer.
| This patch fixes that and others in libstdc++.
|
| OK?
| _Rep_type _M_t; // red-black tree representing multiset
| public:
| - typedef typename _Rep_type::const_pointer pointer;
| + typedef typename _Rep_type::pointer pointer;
I prefer the change be
+ typedef typename _Alloc::pointer pointer;
To rflect Standard wording. Same for the rest.
With those changes, the patch is OK.
-- Gaby