This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: messages private members
- From: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- To: Pétur Runólfsson <peturr02 at ru dot is>
- Cc: "Benjamin Kosnik" <bkoz at redhat dot com>, <libstdc++ at gcc dot gnu dot org>
- Date: 03 Oct 2003 11:34:16 +0200
- Subject: Re: messages private members
- Organization: Integrable Solutions
- References: <07D05A69A3D0C14FAEA60C3ACE8E5564028F55DB@mail.ru.is>
Pétur Runólfsson <peturr02@ru.is> writes:
| Gabriel Dos Reis wrote:
| > | >--- config/locale/gnu/messages_members.h 2 Oct 2003 21:12:46 -0000
| > | >***************
| > | >*** 39,45 ****
| > | > : facet(__refs)
| > | > {
| > | > #if !(__GLIBC__ > 2 || (__GLIBC__ == 2 && __GLIBC_MINOR__ > 2))
| > | >! _M_name_messages = _S_c_name;
| > | > #endif
| > | > _M_c_locale_messages = _S_get_c_locale();
| > | > }
| > | >--- 39,45 ----
| > | > : facet(__refs)
| > | > {
| > | > #if !(__GLIBC__ > 2 || (__GLIBC__ == 2 && __GLIBC_MINOR__ > 2))
| > | >! _M_name_messages = _S_get_c_name();
| > | > ^^
| > | >
| > | >needs "messages<_CharT>::" to become dependent (still better,
| > | >"locale::facet::"), or else error.
| [...]
| >
| > The reason the error does not appear in time_members.h is that
| > locale::facet is a NON-dependent base of __timepunct so usual name
| > lookup looks there and find it.
| > That is not the case for messages_byname<_CharT> which has the
| > dependent base class messages<_CharT>.
|
| This code is in messages<_CharT>, not messages_byname<_CharT>.
Right. The code in question is
template<typename _CharT>
messages_byname<_CharT>::messages_byname(const char* __s, size_t __refs)
: messages<_CharT>(__refs)
{
#if !(__GLIBC__ > 2 || (__GLIBC__ == 2 && __GLIBC_MINOR__ > 2))
if (this->_M_name_messages != _S_get_c_name())
delete [] this->_M_name_messages;
It is now corrected by Benjamin's commit.
-- Gaby