This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Cleanup in istream.tcc

From: Paolo Carlini <pcarlini at unitus dot it>
To: Martin Sebor <sebor at roguewave dot com>
Cc: libstdc++ at gcc dot gnu dot org, Benjamin Kosnik <bkoz at redhat dot com>, Pétur Runólfsson <peturr02 at ru dot is>
Date: Tue, 23 Sep 2003 23:37:38 +0200
Subject: Re: [PATCH] Cleanup in istream.tcc
References: <07D05A69A3D0C14FAEA60C3ACE8E5564028D0E27@mail.ru.is> <3F709055.7000008@roguewave.com>

Martin Sebor wrote:

Pétur Runólfsson wrote:

The call to setstate is redundant since sentry::operator bool() only
returns false if sentry::sentry() has already set failbit.


Not necessarily. Failbit (or any other bit) may have been set prior
to the call to the ctor, in which case the sentry might do nothing
and the input function would then call setstate(failbit).

In particular, readsome() is explicitly required to set failbit when
the sentry is false.

[snip]

Thanks Martin.

Pétur? Benjamin? I'm afraid we have to revert this...

Paolo.

Follow-Ups:
- Re: [PATCH] Cleanup in istream.tcc
  - From: Gabriel Dos Reis

References:
- [PATCH] Cleanup in istream.tcc
  - From: Pétur Runólfsson
- Re: [PATCH] Cleanup in istream.tcc
  - From: Martin Sebor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]