This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [libstdc++ patch] Fix basic_string::_S_construct null pointer check


On Mon, Jul 14, 2003 at 09:06:21PM +0200, Gabriel Dos Reis wrote:
> Secondly, what are the use cases of __null_pointer()?

So far, exactly one.  :-)  And unfortunately, only people familiar with
the syntax of __builtin_expect will know that the parameter must be a
boolean value.  To other readers, additional clarity can't hurt.


> But I do not have a strong feeling against __null_pointer being
> renamed to __is_null_pointer.

I would personally prefer __is_null_pointer.  I'm not a huge LISP-style fan,
and __is_* goes well with the proposed reflection-style naming scheme.


Phil

-- 
If ye love wealth greater than liberty, the tranquility of servitude greater
than the animating contest for freedom, go home and leave us in peace.  We seek
not your counsel, nor your arms.  Crouch down and lick the hand that feeds you;
and may posterity forget that ye were our countrymen.            - Samuel Adams


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]