This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Fix libstdc++/11378 (take2) + xsputn optmizations



----- Original Message -----
From: Paolo Carlini <pcarlini@unitus.it>
Date: Monday, July 7, 2003 8:01 am
Subject: Re: [Patch] Fix libstdc++/11378 (take2) + xsputn optmizations

> Jerry Quinn wrote:
> 
> > > -            int_type __tmp = this->overflow();
> > > +            const int_type __tmp = this->overflow();
> >
> >Why this chunk?  It seems pointless.
> >
> What do you mean by "pointless"? It seems to me that constifying 
> const 
> variables is always a good thing. Don't you agree?

Yes, but...

It seems like overkill to make a basic datatype on the stack const.  I don't see how it adds anything to do this.

Jerry



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]